EQS-1110: Add Playwright integration - #1963
Open
petechd wants to merge 29 commits into
Open
Conversation
VirajP1002
reviewed
Aug 18, 2026
ems-sato
reviewed
Aug 18, 2026
ems-sato
left a comment
ems-sato
left a comment
There was a problem hiding this comment.
Nice work, I think it looks really good. I added a couple of comments and I will try to go through it again as I might have missed more.
Another point I was going to add would be if it would be really helpful if we could update the README to reflect the tests changes and match with the new workflow.
ems-sato
reviewed
Aug 25, 2026
ems-sato
reviewed
Aug 25, 2026
ems-sato
approved these changes
Aug 27, 2026
ems-sato
left a comment
ems-sato
left a comment
There was a problem hiding this comment.
LGTM, one last comment from me is that it would be good to update README to reflect the tests changes. Not a blocker so happy to approve.
Contributor
Author
|
Had to remove the division into projects in the .ts file (and README mention) as it was not compatible with shards, run all suites for every worker. |
petechd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Based on the PR in Census Runner: ONSdigital#82 by @ajmaddaford. This is functional tests migration to Playwright and Typescript. Like in the original PR, we preserve the existing behaviour while changing the automation framework. Compared to the Census Runner PR, these extra specs had to be added, since they didn't exist at the time of the fork:
In the original PR some adjustments were made to prevent flakiness. So some tests slightly changed but the assertions should be the same.
How to review
Visually check the specs and reworked Makefile, generate_pages, pull_request.yaml (are all actions needed). Check if the Webdriver was completely removed. Use Andrew's PR as reference: ONSdigital#82.
Checklist