add slack notification for slow bundle publish - #160
Open
andre-urbani wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add slack alert for when bundle publish exceeds 59 seconds
Jira - https://officefornationalstatistics.atlassian.net/browse/DIS-5302
How to review
To test locally -
BUNDLE_PUBLISH_SLOW_THRESHOLD=1msbefore starting bundle-api just so that a normal speed publish will exceed it (59s delay isn't really possible to trigger manually)/bundles/{id}/contents, then transition it DRAFT > IN_REVIEW > APPROVED via PUT/bundles/{id}/stateBUNDLE_PUBLISH_SLOW_THRESHOLDunset and repeat steps 2-5. Confirm the alarm log line does not appear for a normal speed publishWho can review
Anyone