Skip to content

Add files of first version of plugin Bg Remover - #436

Open
joselmm wants to merge 4007 commits into
ONLYOFFICE:masterfrom
joselmm:bg-remover-plugin
Open

Add files of first version of plugin Bg Remover#436
joselmm wants to merge 4007 commits into
ONLYOFFICE:masterfrom
joselmm:bg-remover-plugin

Conversation

@joselmm

@joselmm joselmm commented Aug 27, 2025

Copy link
Copy Markdown
3

The original code (vite + react ) is in this repo https://github.com/joselmm/bg-remove
baseUrl (just to test): https://joselmm.github.io/bg-remove/dist/

@joselmm joselmm changed the title Add files of version of plugin Bg Remover Add files of first version of plugin Bg Remover Aug 27, 2025
@trofim24

Copy link
Copy Markdown
Contributor

Hi @joselmm, thanks for submitting the BG Remover plugin!

I've reviewed the plugin against our guidelines and found a couple of issues that need to be addressed before we can merge.

Blocked Issues
Plugin not registered in store/config.json

Please add the plugin entry to store/config.json:

{ "name": "bg-remover", "discussion": "" }
Missing offered field in config.json

The provider field should be renamed to offered to follow the plugin configuration standard:

"offered": "joselmm",

Suggestions (Optional)
Consider adding separate dark/light toolbar icons in resources/dark/ and resources/light/ directories with scaled versions (@1.25x, @1.5x, @1.75x, @2x) for better theme support.
Consider using the icons2 array format in config.json for full DPI scaling support.
Please make these changes and update the PR. Let me know if you have any questions!

@trofim24 trofim24 added the waiting feedback Issues that we waiting to be answered from author of issue label Mar 26, 2026
@joselmm

joselmm commented Mar 26, 2026

Copy link
Copy Markdown
Author

Thanks for the suggestions, I'll let you know as soon as I make the necessary changes.

@joselmm

joselmm commented Mar 27, 2026

Copy link
Copy Markdown
Author

Hi @trofim24,

I have updated the PR following your review:

Blocked Issues:

Registration: Added { "name": "bg-remover", "discussion": "" } to store/config.json.

Field Rename: Changed provider to offered in config.json.

Suggestions (Implemented):

Adaptive Icons: Created resources/dark/ and resources/light/ directories with all scaled versions (@1.25x, @1.5x, @1.75x, @2x).

Scaling Support: Updated config.json using the Smart URL adaptive icon format for full DPI scaling support (as per v9.0+ standards).

I also resolved the merge conflicts in store/config.json. Ready for final review! Thanks.

@konovalovsergey
konovalovsergey force-pushed the master branch 2 times, most recently from 2357d41 to 044a5da Compare April 2, 2026 17:08
@drape3a drape3a mentioned this pull request Jul 3, 2026
@drape3a drape3a removed the waiting feedback Issues that we waiting to be answered from author of issue label Jul 7, 2026
@drape3a

drape3a commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Thanks for the updates.
One more thing: please move the plugin icon path from the array to a top-level string (see example). Currently the icon doesn't appear in the toolbar because of this.

@joselmm

joselmm commented Jul 14, 2026

Copy link
Copy Markdown
Author

Hi @drape3a, thanks for the guidance! I have updated the config.json to use a top-level string for the icon path instead of an array, following the example you provided. This should resolve the toolbar display issue. Thanks again!

@drape3a

drape3a commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Hi @joselmm,
Could you please add a README.md file to the repository? It's displayed in the plugin manager under "Info & Support", so it helps users understand what the plugin does and how to use it.

joselmm added 2 commits July 16, 2026 14:59
Added detailed README for Background Remover plugin, including features, usage instructions, and support information.
Updated image paths in README for BG Remover plugin.
@joselmm

joselmm commented Jul 16, 2026

Copy link
Copy Markdown
Author

Hi @drape3a, done! I've added the README.md file to the plugin folder. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.