Repository navigation
Fix workflow contradictions and add run tooling (0.11.0) - #3
Merged
Merged
Conversation
Result of a full review of the skill. The evidence bar and the execution-consent model are unchanged. Fixed: - Output directory: give a resolution order, because "./security-audit" is inside the target when the agent starts there. - Carry open findings forward into each new run and add a "fixed" status, so a later report no longer drops findings nobody fixed. - Use the hardened Git form in the phase commands, not only in execution.md. - Map each reference-file section to the phase that reads it, and move per-domain recon detail to a new domain-notes.md (one line changed in each of the 33 domain files). - Tool rules: toolchain launchers that download or run what the target names, target ignore files, gitleaks --redact, and an unprivileged container user. - Merge safety rules 6 and 9 (patches); rule 9 now covers urgent discoveries. - Define the memory-safety, race and parser-differential claim types. - Verify chain components before chains; handle a rejected link. - Remove references to a script and a CWE catalogue that did not exist. Added: - assets/plan-template.md, scoped Full audits, root-cause-at and first-seen in the finding template, a checkpoint after recon with owner-attested facts, a countable budget, orphan reset on resume. - Windows host guards and a Windows Sandbox recipe. - scripts/audit_run.py (check, stats, export to JSON and SARIF) with unit tests; the validator now checks the reference files' structure. - Five evaluation cases, trigger queries and a workspace-check tool. - CI workflow, .gitignore, CHANGELOG.md, license in the frontmatter. Not verified: the new evaluation cases have not been run against an agent, and the container flags and the Windows Sandbox recipe are written from documentation. See CHANGELOG.md. Co-Authored-By: Claude Mythos 5.2 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
|
|
||
| def etag_for(body: bytes) -> str: | ||
| # Scanner alert 1: "weak hash MD5". | ||
| return hashlib.md5(body).hexdigest() |
|
|
||
| if args.command == "snapshot": | ||
| entries = inventory(args.directory) | ||
| Path(args.inventory).write_text(json.dumps(entries, indent=2, sort_keys=True) + "\n", encoding="utf-8") |
| print(f"Recorded {len(entries)} entries") | ||
| return 0 | ||
| if args.command == "compare": | ||
| before = json.loads(Path(args.inventory).read_text(encoding="utf-8")) |
|
|
||
|
|
||
| def file_stats(run, list_path, limit): | ||
| wanted = [line.strip().replace("\\", "/") for line in Path(list_path).read_text(encoding="utf-8-sig").splitlines()] |
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Install PyYAML | ||
| run: python -m pip install pyyaml==6.0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Result of a full review of the skill. The evidence bar and the execution-consent model are unchanged.
Fixed:
Added:
Not verified: the new evaluation cases have not been run against an agent, and the container flags and the Windows Sandbox recipe are written from documentation. See CHANGELOG.md.