Repository navigation
feat: model multi-edit, create, rename and delete tools and registry credentials (C18-C20) - #40
Open
James-Chapman wants to merge 5 commits into
Open
James-Chapman wants to merge 5 commits into
James-Chapman wants to merge 5 commits into
Conversation
Add approval-gated workspace_multi_edit_file (1 to 16 exact replacements, one checkpointed apply) and workspace_create_file (exclusive create, no checkpoint). Both reuse the file_write approval and writers-stopped gate under their own digest domains. Tool schema 0.4.0, version 0.36.0, ADR-0054. Windows missing paths now classify as the recoverable not_found. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Bind one stored secret, bearer or basic, to one declared origin of a package-network profile and send it from the trusted packages fetch as a sensitive Authorization header, only to the longest matching origin. A bound secret that cannot be read refuses the fetch before anything is sent or recorded. Journals record only the opaque credential id. Phase C20, ADR-0056, version 0.37.0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add approval-gated workspace_rename_file (no-replace rename, no checkpoint) and workspace_delete_file (removal after a durable checkpoint). Both reuse the file_write approval and writers-stopped gate under their own digest domains. Operation records gain an optional kind (replace or remove); trusted file restore --removed recreates a deleted file. Tool schema 0.5.0, version 0.38.0, ADR-0055. Linux paths are not compiled or run here. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
CodeQL flagged cleartext logging: the validation test loops printed the secret bytes and the validation result in their failure messages. They now name only the case index and auth scheme. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Phase C18 to C20: four new approval-gated model file tools, and registry credentials for
packages fetch. Version 0.38.0.Stacked on
codex/checkpoint-ledger-compaction. There are three commits, one per phase, and each can be reviewed on its own.What changed
795d8ce, 0.36.0, ADR-0054)workspace_multi_edit_filemakes 1 to 16 exact replacements in one existing file through one checkpointed apply.workspace_create_filecreates a new file exclusively, without a checkpoint.not_found. This also changes read, list and edit.f274094, 0.37.0, ADR-0056)workspace package-credential-setandpackage-credential-removebind one stored secret, bearer or basic, to one declared origin of a package-network profile.packages fetchsends the secret as a sensitiveAuthorizationheader, only to the longest matching origin.2a8b529, 0.38.0, ADR-0055)workspace_rename_filenever replaces an existing name and takes no checkpoint.renameat2(RENAME_NOREPLACE)and checks the destination inode afterwards.FileRenameInformationExwith POSIX semantics and no replace flag.workspace_delete_filedeletes a regular file of up to 1 MiB after a durable checkpoint of its bytes.unlinkatand then requiresnlink == 0. Otherwise it reports the outcome as uncertain.replaceorremove).file restore --removedrecreates a deleted file with an exclusive create.file_writeapproval and the writers-stopped gate, each under its own digest domain.Why it changed
These are the remaining Phase C items chosen for this round. The model could make only one exact edit per approval and could not create, rename or delete files. Package fetches could not reach registries that need authentication.
Tests
2a8b529): fmt and clippy are clean. 51 suites, 1,092 passed, 0 failed. The native rename and removal tests were confirmed by name.Updated
crates/omgcode-cli/tests/model_tools.rs,crates/omgcode-core/tests/turn_runtime.rs,crates/omgcode-core/tests/approval_review.rsandcrates/omgcode-app/tests/desktop_approvals.rscover the new tools, digests and approval binding.crates/omgcode-core/src/files/replacement/tests.rs,crates/omgcode-core/tests/replacement_records.rs,crates/omgcode-cli/tests/checkpoint_lifecycle.rsandcrates/omgcode-cli/tests/file_workflow.rscover remove records and restore of removed files.crates/omgcode-platform/src/broker/windows/replacement/tests.rscovers handle-based removal.crates/omgcode-core/src/control/package/tests.rsandcrates/omgcode-core/src/packages/tests.rscover credential binding and fetch.crates/omgcode-desktop/ui/tests/approvals.test.tsandmock.test.tscover the "File change" approval label.New
crates/omgcode-cli/tests/package_credential_workflow.rscrates/omgcode-core/src/control/package/credential/tests.rscrates/omgcode-core/src/packages/authorization/tests.rscrates/omgcode-core/src/test_support.rs🤖 Generated with Claude Code