[19.0][IMP] base_tier_validation_correction: UI polish#27
Open
bosd wants to merge 2 commits into
Open
Conversation
…iews - Apply many2many_avatar_user / many2one_avatar_user on user fields (old/new reviewers in form + items, create_uid in form and list). - Add Model and creation columns to the list view. - Search view: add model_id field, "My Corrections" filter, per-state filters, and a Status groupby; default the action to group by Status. - Fix duplicate <filter name="correction_type"> in the search view that silently shadowed the Correction Type groupby with the Model one.
Contributor
|
Hi @kittiu, |
OCA-git-bot
added
series:19.0
mod:base_tier_validation_correction
… classes
- Fix button label typo: "Make Correcton" -> "Make Correction".
- Fix the Cancelled badge: decoration-danger="state in 'cancel'" was a
substring match against the literal "cancel" -- it accidentally
matched 'c', 'a', 'n', 'e', 'l' if state were ever a single char.
Use decoration-danger="state in ['cancel', 'revert']" so both
terminal states get the danger badge (instead of the Reverted state
having no decoration at all).
- Replace legacy classes:
- oe_grey -> text-muted (Bootstrap 5 muted-text equivalent;
oe_grey is no longer documented as a public Odoo helper).
- oe_edit_only "Name" hint above the title: drop entirely; the
<field placeholder="..."> already covers the same UX in edit
mode, and the span left a stray "Name" label visible in v19.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI improvements for the
tier.correctionviews.many2many_avatar_usertoold_reviewer_ids/new_reviewer_ids(form view, items inline list and form).many2one_avatar_usertocreate_uid(form view and list view).create_uid(avatar) andcreate_date.model_idsearchable field.create_uid = uid).<filter name="correction_type">. The duplicate name caused the Model groupby to shadow the Correction Type one. Renamed togroup_state/group_correction_type/group_model.Test plan