[19.0]]MIG] helpdesk_mgmt_timesheet: Migration to 19.0 - #1102
Open
etobella wants to merge 139 commits into
Open
Conversation
Currently translated at 100.0% (20 of 20 strings) Translation: helpdesk-13.0/helpdesk-13.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-13-0/helpdesk-13-0-helpdesk_mgmt_timesheet/es/
Before this commit, in any view with ticket_id present but unused the onchange would be called and set project and task to False. It was found while trying to integrate project_timesheet_time_control with helpdesk_mgmt_timesheet, where this onchange overrides the results of default_get. After this commit, if a helpdesk ticket is not present when calling onchange, project and task ids are not reset to False.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-13.0/helpdesk-13.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-13-0/helpdesk-13-0-helpdesk_mgmt_timesheet/
Currently translated at 95.0% (19 of 20 strings) Translation: helpdesk-13.0/helpdesk-13.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-13-0/helpdesk-13-0-helpdesk_mgmt_timesheet/hu/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-13.0/helpdesk-13.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-13-0/helpdesk-13-0-helpdesk_mgmt_timesheet/
…lpdesk.ticket.team
Currently translated at 100.0% (32 of 32 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_timesheet/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_timesheet/
Currently translated at 100.0% (39 of 39 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_timesheet/it/
Currently translated at 100.0% (39 of 39 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_timesheet/tr/
hours optional in treeview
Currently translated at 100.0% (39 of 39 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_timesheet/fr/
Currently translated at 100.0% (39 of 39 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_timesheet/es/
…timesheet_table In Odoo 17.0+ the parent template hr_timesheet.timesheet_table removed the nbCols variable (now using static colspan='100'). The inheritance was still trying to increment nbCols, causing a NameError when rendering the timesheet report with tickets linked to timesheet lines.
Currently translated at 82.0% (32 of 39 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_timesheet/sl/
Currently translated at 100.0% (39 of 39 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_timesheet/sl/
…have access to the project Use case example: - Create a user with permissions under Helpdesk and Project > User - Create a project with visibility set to Invited internal users (private) - Create a ticket linked to the previously created user and project - When attempting to access the ticket with the created user, the user should be able to access it successfully without any errors being displayed TT63960
OCA-git-bot
added
series:19.0
mod:helpdesk_mgmt_timesheet
Member
Author
|
@victoralmau @pedrobaeza I took the last version of 18 as base and just added the migration commit from #999. After that a small fix was necessary. |
victoralmau
suggested changes
Sep 4, 2026
victoralmau
left a comment
victoralmau
left a comment
Member
There was a problem hiding this comment.
Code review OK but tests fail
Demo data cannot be used in the tests at this time, so it will need to be created within the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes #999 and adds a small fix to fix the migration
/ocabot migration helpdesk_mgmt_timesheet