Conversation
This reverts commit da2285f.
SirPyTech
force-pushed
the
18.0-imp-helpdesk_mgmt-user_access
branch
from
August 24, 2026 16:03
b24cb0a to
71511ca
Compare
SirPyTech
marked this pull request as ready for review
August 24, 2026 16:03
pedrobaeza
reviewed
Aug 24, 2026
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
But is this subscribing to "Ticket created" to the author of the email?
Contributor
Author
Hi, thanks for having a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps:
Current behavior:
There is no link to open the ticket in the email, more precisely there is a link that is not visible because it has no content.
Expected behavior:
The email shows a link to open the ticket.
Additional notes:
In order to implement this, I reverted #508 that used
mass_mailcomposition mode in order to ensure an email is sent when a ticket is created (ref. #508 (comment)).I reverted it because the creation email should be sent as a creation notification and not as a "stage change" email by setting the email template in the "New" stage: it is indeed weird to receive an email "Stage changed to New" when you have just submitted a ticket.
Moreover, the
mass_mailcomposition mode is not needed in any other module implementing the same functionality (like https://github.com/odoo/odoo/blob/19fa4584c81bd3c636f244298d40e7fc1125e6f3/addons/project/models/project_task.py#L1576-L1580) and has the side effect of making the link in the email disappear (becauserecord_nameis set toFalsein https://github.com/odoo/odoo/blob/19fa4584c81bd3c636f244298d40e7fc1125e6f3/addons/mail/wizard/mail_compose_message.py#L967).Without the
mass_mailcomposition mode the email was indeed no more sent upon creation, that's why I added another commit to use themail_notify_authorcontext that actually fixes that issue, a test, and a few notes in Configuration about how such behavior should be achieved.Sorry for the long explanation, email and its subtypes is a complicated topic so I spent some time searching through
mail.threadmodel for the correct way to implement all this.@victoralmau and @pedrobaeza you were involved in the specific discussion about this (#508 (comment)) in the reverted PR and sure know more than me this topic, please let me know if I missed something or more in general what you think about this 🙏