[19.0][MIG] web_leaflet_lib: Migration to 19.0#464
Open
agiuseppe28 wants to merge 21 commits into
Open
Conversation
…aflet_lib, to be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)
- Bump version. - Remove obsolete hook. (that was usefull during the refactoring done here OCA#380)
Currently translated at 100.0% (1 of 1 strings) Translation: geospatial-17.0/geospatial-17.0-web_leaflet_lib Translate-URL: https://translation.odoo-community.org/projects/geospatial-17-0/geospatial-17-0-web_leaflet_lib/it/
Odoo minifies javascript sources when adding those to asset bundles. Having the unminified versions available is needed for debugging. The OCA contributor guidelines state: 'Never add minified Javascript libraries'.
…mo data Adding "leaflet.tile_url" ir.config_parameter even without demo data. The demo value of leaflet.tile.url is defined in the post init hook.
Rational: for the time being, nearby markers are not very visible. With this plugin, markers are grouped if it's not possible to display all markers. also it is possible to see markers that are in the same address. (that is not possible for the time being
| @@ -1 +1,2 @@ | |||
| - Sylvain LE GAL (<https://www.twitter.com/legalsylvain>) | |||
| - Giuseppe Ardoselli (<https://github.com/agiuseppe28>) | |||
Contributor
There was a problem hiding this comment.
thanks for porting this module.
Not sure that asking to an IA to migrate a module, and just bump a version in a manifest is a "contribution".
Don't you think ?
Author
There was a problem hiding this comment.
No problem I reverted CONTRIBUTORS.md to your entry only. You're right that a version bump isn't much of a contribution and to be fair credit wasn't even the point. I need the module on 19.0 for some downstream work and would rather upstream the migration than carry a fork, also because the module was already migration ready, maybe someone could benefit from this. If PR still needs something else, I'd be glad to address it.
agiuseppe28
force-pushed
the
19.0-mig-web_leaflet_lib
branch
from
65857a1 to
ff3f4d9
Compare
legalsylvain
approved these changes
Jun 18, 2026
legalsylvain
left a comment
legalsylvain
left a comment
Contributor
There was a problem hiding this comment.
diff review. no test.
thanks !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
web_leaflet_libto 19.0.git format-patch | git amfrom 18.0 (original authors kept).19.0.1.0.0.base; no functional change — vendored Leaflet assets carried over as-is.ir.http.session_info()override and their.config_parameterdefaults (leaflet.tile_url,leaflet.copyright) were verified locally, and the static Leaflet assets are served correctly.web_leaflet_libwas not listed in the migration checklist of #413 (added on 18.0 after that issue was generated — see the missing-modules FAQ).cc @legalsylvain (original author/maintainer).