[18.0][MIG] edi_exchange_deduplicate_oca: Migration to 18.0#242
[18.0][MIG] edi_exchange_deduplicate_oca: Migration to 18.0#242Ricardoalso wants to merge 9 commits into
Conversation
Currently translated at 100.0% (12 of 12 strings) Translation: edi-framework-16.0/edi-framework-16.0-edi_exchange_deduplicate_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-16-0/edi-framework-16-0-edi_exchange_deduplicate_oca/it/
Ricardoalso
force-pushed
the
18.0-mig-edi_exchange_deduplicate_oca_v2
branch
2 times, most recently
from
6e7bd0d to
fc8eda0
Compare
|
This PR has the |
| "author": "Camptocamp,Odoo Community Association (OCA)", | ||
| "maintainers": ["simahawk", "etobella"], | ||
| "website": "https://github.com/OCA/edi-framework", | ||
| "depends": ["edi_component_oca", "edi_queue_oca"], |
There was a problem hiding this comment.
Do you really need component and queue for this? can you handle the same only depending on edi_core_oca?
There was a problem hiding this comment.
Indeed, dependency confusion in a view. It is now corrected ✔️
Thanks @etobella !
Ricardoalso
force-pushed
the
18.0-mig-edi_exchange_deduplicate_oca_v2
branch
from
fc8eda0 to
050ec1c
Compare
OCA-git-bot
added
mod:edi_exchange_deduplicate_oca
etobella
left a comment
etobella
left a comment
There was a problem hiding this comment.
edi_component_oca is only used for testing. You can remove it by redoing the tests.
| # Copyright 2024 Camptocamp | ||
| # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl). | ||
|
|
||
| from odoo.addons.edi_component_oca.tests.common import ( |
There was a problem hiding this comment.
You should redo the tests without edi_component_oca
There was a problem hiding this comment.
Tests are now refactored and the edi_component_oca dependecy is removed in a fixup commit ✔️
|
@OCA/edi-framework-maintainers, could you merge this one to allow me the oca-port from 18 and not 16 please 🙏 |
| class EDIDeduplicateTestCase(EDIBackendCommonTestCase): | ||
| def setUp(self): | ||
| super().setUp() | ||
| self.loader = FakeModelLoader(self.env, self.__module__) |
There was a problem hiding this comment.
we don't need FakeModelLoader in v19.
See https://github.com/OCA/edi-framework/blob/19.0/edi_core_oca/tests/test_edi_configuration.py#L46
There was a problem hiding this comment.
here it is the V18 no ? shall we update this right now in prevention ? ( i will keep that in mind for my PR :) )
8 participants
No description provided.