Skip to content

[17.0][MIG] currency_rate_update_wise#224

Open
klodr wants to merge 1 commit into
OCA:17.0from
klodr:17.0-mig-currency_rate_update_wise
Open

[17.0][MIG] currency_rate_update_wise#224
klodr wants to merge 1 commit into
OCA:17.0from
klodr:17.0-mig-currency_rate_update_wise

Conversation

@klodr

@klodr klodr commented Jun 20, 2026

Copy link
Copy Markdown

currency_rate_update_wise → 17.0

Forward-port of the Wise.com exchange-rate provider from 14.0 to 17.0.
Framework migration only, no functional change.

Notes for reviewers

  • Hermetic tests: the Wise HTTP layer (_wise_provider_retrieve) is mocked —
    no network access needed in CI.
  • Carries a small, non-blocking helper that logs a warning when the configured
    API token still uses the legacy UUID format (Wise UUID → JWT migration).

@OCA-git-bot OCA-git-bot added series:17.0 mod:currency_rate_update_wise Module currency_rate_update_wise labels Jun 20, 2026
@klodr klodr force-pushed the 17.0-mig-currency_rate_update_wise branch from 8466d91 to 6687288 Compare June 20, 2026 06:49
Forward-port of the renamed and hardened Wise exchange-rate provider introduced
on 14.0 (rename from currency_rate_update_transferwise + security fixes; see the
14.0 history for the rationale and the OpenUpgrade rename). Framework migration
only, no functional change.

Signed-off-by: Claude Perrin <klodr@users.noreply.github.com>
@klodr klodr force-pushed the 17.0-mig-currency_rate_update_wise branch from 6687288 to b53579b Compare June 20, 2026 08:05
@klodr

klodr commented Jun 20, 2026

Copy link
Copy Markdown
Author

A note on the red CI, for reviewers:

The only failing checks are test with OCB / test with Odoo, and they fail solely on the pre-existing currency_rate_update_xe module — its test_cron / test_wizard make real network calls to xe.com (which no longer returns usable data), so they assert 0 != 1. This is unrelated to this PR.

currency_rate_update_wise itself installs cleanly and all 10 of its tests pass — the Wise HTTP layer is mocked, so no network access is needed in CI. The xe.com test issue is already addressed for 17.0 in #218 (and #216 for 16.0, #220 for 14.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:currency_rate_update_wise Module currency_rate_update_wise series:17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants