[18.0][FIX] web: preserve report header top padding in PDF - #1344
Open
miquelrosell99 wants to merge 1 commit into
Open
[18.0][FIX] web: preserve report header top padding in PDF#1344miquelrosell99 wants to merge 1 commit into
miquelrosell99 wants to merge 1 commit into
Conversation
Commit 0184f22 moved report margins to CSS, but the padding applied to .header inside .o_body_pdf only. When wkhtmltopdf renders the header through web.minimal_layout, the header is wrapped in #minimal_layout_report_headers, so the 11 mm top padding was lost and the company logo sits flush against the top of the page. Add the same padding-top to #minimal_layout_report_headers .header so the PDF output matches the browser preview again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Odoo 18.0 commit
0184f2236804moved report margins into CSS and added.header { padding-top: 11mm; }inside.o_body_pdf.o_css_margins. However, when wkhtmltopdf renders the header throughweb.minimal_layout, the header is wrapped in#minimal_layout_report_headers, so the 11 mm top padding is silently dropped. The result is that the company logo sits flush against the top edge of the page in PDF output.This patch applies the same
padding-topto#minimal_layout_report_headers .header, restoring the intended spacing in generated PDFs.Steps to reproduce
Fix
Add the missing SCSS rule: