Repository navigation
fix: 删除未接线的 ThoughtsPane,恢复 nightly 预检(10-22 定时挂) - #316
Merged
Merged
Conversation
There was a problem hiding this comment.
审查结论:无阻断性问题 ✅
本 PR 为单一文件删除(ThoughtsPane.tsx,-266 行),逐项核实了 PR 描述中的关键论断,均与仓库实际状态一致:
1. 确实无任何引用方(已验证)
- 全仓 grep `ThoughtsPane`:代码零命中。仅 `docs/ppt-generation-ux-audit-20261020.zh-CN.md:288`、`:333` 两处散文提及(记录的就是这 10 条既存类型错)。
- barrel 文件 `detail-panels/index.ts` 从未导出过它;无测试、无动态 `import()`、无字符串引用。
2. 类型错根因属实(已验证)
- 当前 `useEmergence`(`ported/hooks/useEmergence.ts:9-13`)入参仅 `{ roomId, focus }`,返回值(`useEmergence.ts:94-103`)只含漫步侧状态(`wanderResult`/`wanderLoading`/`extendWalk` 等)。被删组件解构的 `focusResult`/`focusLoading` 与传入的 `locked` 均为已移除 API,hook 注释(`useEmergence.ts:11`「聚焦世界已迁 useFocusMindmap」)亦印证迁移事实。
- `git log --follow` 确认该文件由 abf1940(10-21)新增,dcc04790 / b748b81 为聚焦迁移提交,与 PR 描述的时间线一致。
3. 无连带破坏(已验证)
- 留存的 `VeinGraphCanvas.tsx`、`detail-panels/EmergenceCard.tsx` 不依赖 `useEmergence`(仅引 Pixi 图组件 / radix / DTO 类型),自身类型干净,孤儿化不影响 tsc 通过。
次要备注(不阻断,供后续参考)
- 同批孤儿代码:abf19404 同 commit 引入的 `VeinGraphCanvas.tsx` + `veinGraphModel.ts` + `EmergenceCard.tsx`(合计约 390 行)现均无引用方,仅在彼此间引用。PR 说明已明确为有意保留待重写接线,可接受;但注意 `EmergenceCard` 的 props(`mode="focus"` 等)同样是按旧聚焦语义设计的,后续基于 useRouteMindmap 恢复时并非只换 hook 即可。
- `docs/ppt-generation-ux-audit-20261020.zh-CN.md` 中「10 条既存 ThoughtsPane.tsx 错误」的表述已成历史陈述,属审计文档留痕,无需改动。
同意以删除作为最小修复恢复 nightly 预检;合并后重跑预检确认(PR checklist 第二项)即可。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThoughtsPane.tsx共 10 处类型错:组件解构focusResult/focusLoading、传locked选项,均为useEmergence早已移除的聚焦 API(聚焦世界已在 dcc0479/b748b810 迁往 useRouteMindmap,hook 注释「聚焦世界已迁」即此)。git show abf19404可取回);后续接线时请基于 useRouteMindmap API 恢复。EmergenceCard / VeinGraphCanvas 自身无类型错,未动。Test plan