Resolve the tsc binary in our own cmd function - #5
Merged
NullVoxPopuli merged 1 commit intoAug 25, 2026
Merged
Conversation
nvim-lspconfig d217766 moved the tsc binary resolution into its default root_dir function, cached per root. Our content-mapper override replaces root_dir, so the cache stays empty and the client fell back to a bare 'tsc' that is not on PATH. Resolve <root>/node_modules/.bin/tsc in a self-contained cmd function instead of depending on lspconfig internals. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NullVoxPopuli
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the content-mapper
tscclient failing to spawn (Spawning language server with cmd: { "tsc", "--lsp", "--stdio" } failed) after a recent nvim-lspconfig update.nvim-lspconfig moved the workspace binary resolution for
tscinto its defaultroot_dirfunction, cached per root in a file-localbin_cache. Thecmdfunction reads only that cache. Our override from #4 replacesroot_dirwith the content-mapper project detection, so the cache never fills andcmdfalls back to a baretscthat is not on PATH.This resolves
<root>/node_modules/.bin/tscin a self-containedcmdfunction, so the override no longer depends on lspconfig internals. Verified headlessly against ember-content-mapper's example app: the client attaches, a clean.gtshas zero diagnostics, and hover over a component returns its type.🤖 Generated with Claude Code