fix(tao): align standalone tray popup wheel scroll with DecoratedWindow - #610
Merged
Conversation
Feed tray/overlay/owner-based popup wheel events through the same AWT-shaped dispatch as TaoWindow, apply Windows lines-per-notch via LocalScrollConfig, and paint standalone popup frames inline when already on the main thread so a wheel flood cannot starve MainEventsCleared.
Make disposed volatile, document that rendering is main-thread-only, and add mapper tests so Windows/Linux/macOS scrollAmount policy cannot be silently unified.
Tests no longer mutate TaoMainDispatcher.taoMainThread or swallow leaked fallback frames. Nested work is a drained queue; a posted frame after dispose is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dispatchAwtShapedScroll) after platform mapping (Win32 / AppKit / X11 Button4–7).TaoWindowsScrollConfigon the Windows standalone panel so a notch scrolls the same viewport fraction as aDecoratedWindow(3 lines/notch).scrollAmount = 3, matchingTaoWindowSCROLL_LINE.requestFramepaints immediately when already on the Tao main thread (StandaloneFramePump), so a wheel flood cannot starveMainEventsCleared.Test plan
:decorated-window-tao:ktlintCheckand:detekt:decorated-window-tao:apiDump(no public ABI change)Win32WheelDeltaTest,LinuxWheelDeltaTest,MacOsWheelDeltaTest,TaoWindowScrollTest,TaoSceneTestBatteryDriftTest