fix: Skiko 1.12 encodeToData breakage + update Compose/Nucleus - #428
Merged
Conversation
Skiko 0.150.1 changed Image.encodeToData to take an extra pngCompressionLevel parameter, so the 1.11-compiled artifacts fail at runtime with NoSuchMethodError on apps running Compose 1.12. Source stays compatible; only a recompile against 1.12 is required.
Recompiling against Compose 1.12.0 (Skiko 0.150.1) fixes the NoSuchMethodError on Image.encodeToData reported in NucleusFramework/Nucleus#594.
Skiko 0.150 (Compose 1.12) added a pngCompressionLevel parameter to Image.encodeToData, breaking the synthetic $default bridge across versions in both directions. Fall back to the legacy two-argument overload via reflection when the direct call throws NoSuchMethodError, so the published artifact keeps working on older Skiko runtimes. Fixes NucleusFramework/Nucleus#594
kdroidFilter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Apps running Compose Multiplatform 1.12 crash on the current artifacts (NucleusFramework/Nucleus#594):
Skiko 0.150.1 (shipped with Compose 1.12) added a
pngCompressionLevelparameter toImage.encodeToData, so the synthetic$defaultbridge compiled against an older Skiko nolonger exists — and vice versa: an artifact compiled against 0.150.1 would break the same way on
older runtimes.
Change
compose1.11.1 → 1.12.0 stable (skiko 0.150.1)nucleus/nucleus-plugin2.4.4 → 2.5.0 (built against Compose 1.12)ComposableIconUtils: PNG encoding now catchesNoSuchMethodErrorand falls back to thelegacy two-argument
encodeToData(format, quality)overload via reflection, so the artifacttolerates Skiko signature drift in both directions instead of being pinned to the exact Skiko
it was compiled against.
Verified
./gradlew compileKotlinJvm jvmTest ktlintCheck detektgreenFixes NucleusFramework/Nucleus#594