Feat: respawn in a game - #347
Open
HungryMuttis wants to merge 6 commits into
Open
Conversation
Member
|
Hi! Are you still interested in getting this merged? We're taking contributions targetting the dev branch currently, I doubt many new commits are headed to main until the 26.2 switch |
Author
|
Hello, yes, I am still interested in merging. If there are needed changes, I will be able to look into them in about 1-3 days. |
Member
|
In that case, it would be great if you could re-target this to the dev branch |
Author
|
I have changed the base branch. Let me know if anything else needs to be done. |
# Conflicts: # src/main/java/xyz/nucleoid/plasmid/impl/game/manager/ManagedGameSpace.java # src/main/java/xyz/nucleoid/plasmid/mixin/game/space/PlayerManagerMixin.java
HungryMuttis
marked this pull request as draft
July 26, 2026 19:11
Author
|
There seems to be a bug where if the game ends while a player is in the respawn screen they get put in a ghost state where nothing they do gets registered on the server. I'm currently trying to fix this bug, but would appreciate any help. |
HungryMuttis
marked this pull request as ready for review
July 27, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players are thrown out of the game if they die, this feature would allow games to chose if they want the player to be respawned inside the game or thrown out.
Added 2 new
GamePlayerEvents:REQUEST_RESPAWN: determine if the player should be respawned or thrown out of the gameRESPAWN: allow games to modify the respawned player