Annotate MSBuild in proc calls - #7554
Merged
Merged
Conversation
martinrrm
reviewed
Jul 13, 2026
Member
Author
|
Waiting for #7559 to merge. So that flow insertion does not have to deal with code conflicts. But we could also commit this to the VMR flow PR. Not feeling strongly about any of the approaches |
jebriede
previously approved these changes
Jul 14, 2026
jebriede
left a comment
jebriede
left a comment
Contributor
There was a problem hiding this comment.
Approving with suggestions
Nigusu-Allehu
force-pushed
the
dev-nyenework-annotate-msbuild
branch
from
July 15, 2026 15:28
b1cbd8f to
88309e8
Compare
jebriede
approved these changes
Jul 16, 2026
martinrrm
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14987
Description
dotnet/msbuild#14064 added
[RequiresUnreferencedCode]to MSBuild's build execution APIs. This caused IL2026 errors in NuGet.Client's source build because both NuGet.Build.Tasks.Console and NuGet.CommandLine.XPlatFYI a temporary fix was merged in the VMR by suppressing these warnings. This PR annotates the methods with RUC making them more honest instead of suppressing.
This PR will wait for backflow to avoid conflicts.
PR Checklist