Skip to content

PMC test improvements; remove regions, use a dedicated fixtures folder, improve apex migration skill#7502

Merged
nkolev92 merged 1 commit into
devfrom
dev-nkolev92-pmcTestReviewFollowup
Jun 25, 2026
Merged

PMC test improvements; remove regions, use a dedicated fixtures folder, improve apex migration skill#7502
nkolev92 merged 1 commit into
devfrom
dev-nkolev92-pmcTestReviewFollowup

Conversation

@nkolev92

Copy link
Copy Markdown
Member

Bug

This is a test-only follow-up change; no issue required.

Description

Addresses post-merge review feedback from #7467 (PMC Find-Package / Get-Package test migration):

  • Removed #region blocks from FindPackageCommandTests.cs and GetPackageCommandTests.cs (Coding Guideline 17).
  • Extracted shared test infrastructure into a Fixtures folder — moved the duplicated CmdletRunspaceFixture and TestPSHost into Fixtures/CmdletRunspaceFixture.cs as shared internal classes (registers both Find-Package and Get-Package), eliminating duplication across the two test files. Cleaned up now-unused usings.
  • Fixed a comment typo in GetPackageTestCase.cs (falsy -> false).
  • Updated the apex-migration skill to reference the repo-wide docs/coding-guidelines.md instead of restating common rules; the Style rules section now only lists migration-specific conventions that supplement the common guidelines.

Verified: NuGetConsole.Host.PowerShell.Test builds with 0 warnings/0 errors and all 23 Find/Get cmdlet unit tests pass.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@nkolev92
nkolev92 requested a review from a team as a code owner June 23, 2026 20:11
@nkolev92 nkolev92 changed the title Address PR #7467 review feedback for PMC test migration PMC test improvements; remove regions, use a dedicated fixtures folder, improve apex migration skill Jun 23, 2026
@nkolev92
nkolev92 merged commit f603c8f into dev Jun 25, 2026
20 of 21 checks passed
@nkolev92
nkolev92 deleted the dev-nkolev92-pmcTestReviewFollowup branch June 25, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants