Repository navigation
feat: one phone per brand and one build per ROM on the homepage - #107
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
UI
Overview
The two lists on the homepage weren't saying much. Most supported was ten Pixels in a row, and Recently built was whatever we'd imported last (7 of the 8 were AxionOS). Now the left list is each brand's best-supported phone, and the right is each ROM's newest build on a phone the left one hasn't already got. Both are 8 long. If there ever aren't 8 brands or ROMs to go round, they top up with the next best instead of coming up short.
Issue Number
None
Additional Info
When two phones from a brand have the same number of ROMs, the newer one wins, then the one that's had more ROMs over the years. Recently built leaves same-day ties to the phone's name, since anything smarter just picks Pixels again (CalyxOS and iodéOS put out most of their phones on the same day).
Recently built only counts support that's still live, or a discontinued ROM would get a slot for a build from years ago. There are 9 ROMs and 8 rows, so whichever built least recently misses out (/e/OS, right now).
Also, while I was in there, the header gets a GitHub link where the search box would be, on the pages that already have search in the page itself. It's hidden on phones, since there's no room on the top row and the footer already links to the repo.