chore: stop dependabot proposing SixLabors majors it cannot land - #302
Conversation
ImageSharp 4 and Drawing 3 ship an MSBuild task that validates a Six Labors
license key. It degrades to a warning in Debug but fails the build outright in
Release:
SixLabors.ImageSharp.Drawing.targets(28,5): error : No Six Labors license found.
Please obtain a license from https://sixlabors.com/pricing/
The release workflow runs `dotnet build -c Release` before packing, so the major
bump cannot go green without a purchased licence, no matter what the code does.
On top of that Drawing 3 replaces the IImageProcessingContext Fill/DrawText
extensions with a stateful DrawingCanvas, which would mean rewriting every
drawing call in the test suite for no functional gain.
Pinning to the 3.x/2.x line, which is Apache-2.0 and works.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughChangesDependency update policy
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only limits Dependabot from proposing incompatible SixLabors major upgrades while allowing minor and patch updates to continue; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #299 and #301 — neither can be merged.
Why they cannot go green
ImageSharp 4 / Drawing 3 ship an MSBuild task that validates a Six Labors license key. It is lenient in Debug and strict in Release:
The release workflow runs
dotnet build -c Releasebeforedotnet pack, so with the bump applied:That is a purchase, not a code fix.
Separately, Drawing 3 removes the
IImageProcessingContextFill/DrawTextextension methods entirely and replaces them with a statefulDrawingCanvasbuilt from anImageFrame, takingBrush/Peninstead ofColorandRectangleinstead ofRectangleF. Every drawing call acrossTestHelper,BrushFireTests,FlowFieldTests,GoalBasedPathfinderTestsandJumpPointSearchPathfinderTestswould need rewriting — for test-only visualisation that already works.What this does
Pins the three SixLabors packages to their current major (
3.1.12/2.1.7/2.1.3, still Apache-2.0) and tells dependabot to stop opening major bumps for them, so these PRs do not reappear daily.Minor and patch updates still flow normally.
If the licence is ever bought, drop the
ignoreblock and the migration can be done deliberately.Verified:
dotnet build -c Releasesucceeds on this branch and fails with the bump applied.🤖 Generated with Claude Code
Summary by CodeRabbit