Skip to content

chore: bump all NuGet packages to latest and add Game18NConstString 2851-2868 - #490

Merged
erwan-joly merged 1 commit into
masterfrom
chore/upgrade-all-packages
Aug 14, 2026
Merged

chore: bump all NuGet packages to latest and add Game18NConstString 2851-2868#490
erwan-joly merged 1 commit into
masterfrom
chore/upgrade-all-packages

Conversation

@erwan-joly

@erwan-joly erwan-joly commented Aug 14, 2026

Copy link
Copy Markdown
Contributor
  • Bump MSTest.TestAdapter/TestFramework 4.2.1 -> 4.3.3, Microsoft.NET.Test.Sdk 18.4.0 -> 18.8.1, coverlet.collector 10.0.0 -> 10.0.1
  • Bump Microsoft.CodeAnalysis.CSharp 5.3.0 -> 5.6.0, Verify.MSTest 31.16.1 -> 31.28.0, NosCore.ParserInputGenerator 4.0.0 -> 4.1.0
  • Add Game18NConstString enum entries 2851-2868 (act pillars/meteors/purify, shell engraving, NosBlue rank gating)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added support for 17 additional in-game messages covering dimensional pillars, meteors, purification objectives, mini-bosses, shell engraving, access ranks, and item usage.
    • Expanded messaging for gameplay instructions, restrictions, completion states, and combat objectives.
  • Bug Fixes

    • Improved coverage and consistency for newly supported game messages.

…851-2868

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5bb524af-c8b1-4561-b241-db4870d15606

📥 Commits

Reviewing files that changed from the base of the PR and between b759975 and ee3a520.

📒 Files selected for processing (3)
  • src/NosCore.Packets/Enumerations/Game18NConstString.verified.cs
  • test/NosCore.Packets.Benchmark/NosCore.Packets.Benchmark.csproj
  • test/NosCore.Packets.Tests/NosCore.Packets.Tests.csproj

Walkthrough

The PR adds 17 Game18NConstString enum members and updates package versions in the benchmark and test projects.

Changes

Game18N constants and tooling

Layer / File(s) Summary
Add Game18N message constants
src/NosCore.Packets/Enumerations/Game18NConstString.verified.cs
Adds 17 public enum members for dimensional pillars, meteors, purification, mini-bosses, shell engraving, and rank-based access messages.
Update benchmark and test tooling
test/NosCore.Packets.Benchmark/NosCore.Packets.Benchmark.csproj, test/NosCore.Packets.Tests/NosCore.Packets.Tests.csproj
Updates compiler, test, coverage, parser, and verification package versions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ee3a5

The PR adds localized enum values and updates test and benchmark dependencies; the remaining mapping confirmation is non-blocking, so no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the dependency updates and the addition of Game18NConstString entries, which are the pull request's main changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/upgrade-all-packages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@erwan-joly
erwan-joly merged commit 13fdb30 into master Aug 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant