Shepherd Fixes and Improvements#152
Open
KSMehta11 wants to merge 58 commits into
Open
Conversation
Open
caiodasilva2005
requested changes
Jul 20, 2026
| "[OW] Open wire IC%u C%02u: even=%.3f V, odd=%.3f V, drop=%.3f V (%.1f%%)", | ||
| chip + 1U, cell + 1U, even_voltage, | ||
| odd_voltage, drop_voltage, drop_percent); | ||
| } |
Contributor
There was a problem hiding this comment.
lets trigger critical fault here for safety
Contributor
Author
There was a problem hiding this comment.
Updated to trigger critical fault. I have a 40 second debounce setup currently, so it has a chance to run open wire test atleast twice before triggering shutdown.
| 0.0f; | ||
|
|
||
| if ((chip % 2U) == 0U) { | ||
| send_alpha_cell_s_adc_data( |
Contributor
There was a problem hiding this comment.
we can limit bus traffic if we send two (or more) cells per message potentially
Contributor
Author
There was a problem hiding this comment.
Can address that in a follow up ticket.
jr1221
reviewed
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes #118 #150