best score saving#232
Open
TheJeffreyKuo wants to merge 2 commits into
Open
Conversation
TheJeffreyKuo
requested review from
bracyw and
devmchechi
and removed request for
bracyw and
Copilot
June 2, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
FlappyBird and 2048 best scores now persist locally via QSettings. QSettings are ideal because it the scores are low data values which fits our needs and it has atomic saving for risk management. The game controllers check whenever a final score is better than the recorded best score and saves over the best score if it is.
To Do
Checklist
Closes #231