Wheel Speed#24
Merged
Merged
Conversation
KSMehta11
reviewed
Mar 22, 2026
KSMehta11
reviewed
Mar 22, 2026
KSMehta11
reviewed
Mar 22, 2026
KSMehta11
requested changes
Mar 22, 2026
KSMehta11
left a comment
KSMehta11
left a comment
There was a problem hiding this comment.
Looks good overall, just a couple of minor changes. There are two updates in the MX file: setting the timer prescalers and enabling the input capture interrupt for both timers.
KSMehta11
reviewed
Mar 24, 2026
KSMehta11
reviewed
Mar 24, 2026
KSMehta11
reviewed
Mar 24, 2026
KSMehta11
reviewed
Mar 24, 2026
KSMehta11
reviewed
Mar 24, 2026
KSMehta11
requested changes
Mar 24, 2026
KSMehta11
approved these changes
Mar 30, 2026
KSMehta11
left a comment
KSMehta11
left a comment
There was a problem hiding this comment.
Looks good, nice work. Any further tuning/changes will have to be done after testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wheel Speed
Implemented HALL Effect for Wheel Speed.
Notes
Based off of adcs branch.