Skip to content

#4328 reschedule notification only happens if time changes#4336

Open
glickgNU wants to merge 3 commits into
developfrom
#4328-edit-event-rescheduled
Open

#4328 reschedule notification only happens if time changes#4336
glickgNU wants to merge 3 commits into
developfrom
#4328-edit-event-rescheduled

Conversation

@glickgNU

@glickgNU glickgNU commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Changes

When an meeting/event is edited, the reschedule message only appears when time is changed.

Notes

I had to move the call to EditScheduleSlot, which doesn't have an foundEventType.sendSlackNotifications field, so there could be notifications sent when not wanted. It just feels like a lot more effort for a small want.

Test Cases

  • Changing a non time field such as name of an event doesn't send a notification
  • Changing the hour of an event sends a notification
  • Changing from all day to a specific time and vice versa for an event sends a notification

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintenance] - Edit Event Missend Rescheduled Notif

1 participant