#4244 events attendance#4330
Open
Santiordon wants to merge 8 commits into
Open
Conversation
Steph375
reviewed
Jul 15, 2026
Steph375
left a comment
Steph375
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just a couple of things!
| userCreatedId: string, | ||
| attendeeIds: string[] | ||
| ): Prisma.Meeting_AttendanceCreateInput => ({ | ||
| slackChannelId: `C${Math.random().toString(36).substring(2, 12).toUpperCase()}`, |
Contributor
There was a problem hiding this comment.
these use Math.random and the global faker instead of the seeded one, so they won't be reproducible. can we route them through the injected faker (faker.string.uuid() / faker.string.numeric)
Steph375
previously approved these changes
Jul 16, 2026
wavehassman
self-requested a review
July 17, 2026 00:45
wavehassman
requested changes
Jul 17, 2026
wavehassman
requested changes
Jul 17, 2026
wavehassman
left a comment
wavehassman
left a comment
Contributor
There was a problem hiding this comment.
Big things I noticed:
- Events do not follow their event types required and optional fields
- No event and document date created, you changed it for Meeting Attendance but not these
- approvalRequiredByUserId and approved are linked together so shouldn't be set randomly
I would look at the service functions for events, so you understand how everything is linked
wavehassman
requested changes
Jul 20, 2026
| const CAR_COUNT = 5; | ||
|
|
||
| const FROM_MONTH = 1; // January | ||
| const FROM_MONTH = 5; // May |
Contributor
There was a problem hiding this comment.
why did you change these?
| export const generateEventDateCreated = (faker: Faker, initialDateScheduled: Date): Date => | ||
| addDaysToDate(initialDateScheduled, -faker.number.int({ min: 1, max: 14 })); | ||
|
|
||
| export const generateEventStatus = ( |
Contributor
There was a problem hiding this comment.
does not include confirmed
| ? [...requiredMemberIds, ...this.faker.helpers.arrayElements(optionalMemberIds)] | ||
| : [...this.faker.helpers.arrayElements(requiredMemberIds), ...this.faker.helpers.arrayElements(optionalMemberIds)] | ||
| : []; | ||
| const deniedMemberIds = eventType.requiresConfirmation |
Contributor
There was a problem hiding this comment.
I honestly don't think denied members is ever used
Could just be []
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added the following:
Checklist
yarn.lockchanges (unless dependencies have changed)Closes #4244 (issue #)