#4281 ruleset type admin tools#4329
Open
cielbellerose wants to merge 4 commits into
Open
Conversation
3 tasks
cielbellerose
marked this pull request as ready for review
July 18, 2026 02:12
wavehassman
requested changes
Jul 18, 2026
|
|
||
| const handleDeleteSubmit = () => { | ||
| onDelete(rulesetTypeId, name); | ||
| setShowDeleteModal(false); |
Contributor
There was a problem hiding this comment.
the modal should stay open if there is an error
|
|
||
| const RulesetTypesTable: React.FC = () => { | ||
| const toast = useToast(); | ||
| const { data: rulesetTypes = [], isLoading, error } = useAllRulesetTypes(); |
Contributor
There was a problem hiding this comment.
why does it need to be set to []?
also missing isError
| const { mutateAsync: deleteRulesetType } = useDeleteRulesetType(); | ||
| const [addRulesetTypeModalShow, setAddRulesetTypeModalShow] = useState(false); | ||
|
|
||
| if (error) return <ErrorPage message={error.message} />; |
| }; | ||
|
|
||
| const rulesetTypeTableRows = rulesetTypes.map((rulesetType, index) => ( | ||
| <TableRow> |
| } | ||
| }; | ||
|
|
||
| const RulesetTypeDeleteButton: React.FC<RulesetTypeDeleteButtonProps> = ({ rulesetTypeId, name, onDelete }) => { |
Contributor
There was a problem hiding this comment.
Move this out of RulesetTypesTable's body so it's declared once at module scope, not recreated on every render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Moved logic for adding and deleting ruleset types to admin tools (since only admins had permissions for these actions)
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4281