Skip to content

reject ? bc zenoh #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jr1221 merged 1 commit into from
Jul 15, 2026
Merged

reject ? bc zenoh #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions libs/calypso-cangen/src/validate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ pub enum CANSpecError {
#[error("Duplicate topic names {0}, last seen at message {1}")]
DuplicateTopicNames(String, String),

#[error("Invalid topic name {0}")]
InvalidTopicName(String),

#[error(transparent)] // Pass-through for IO error
IOError(#[from] std::io::Error),
}
Expand Down Expand Up @@ -314,6 +317,12 @@ fn validate_msg(
_msg.desc.clone(),
));
}

// check topic contains valid chars
if _field.name.chars().any(|c| "?#*.".contains(c)) {
_errors.push(CANSpecError::InvalidTopicName(_field.name.clone()));
}

_topics.insert(_field.name.clone());
}

Expand Down
Loading