Skip to content

#630 - prune lingering y-axis when deselecting topic in multi-axis mode#717

Draft
bracyw wants to merge 1 commit into
developfrom
claude/backlog-review-prioritize-rof15t
Draft

#630 - prune lingering y-axis when deselecting topic in multi-axis mode#717
bracyw wants to merge 1 commit into
developfrom
claude/backlog-review-prioritize-rof15t

Conversation

@bracyw

@bracyw bracyw commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Changes

With Multiple Y-Axes enabled, the graph page's y-axis configs are now rebuilt in updateChart from the current data map, so the axis set always matches the selected topics. Previously the multi-y-axis effect only re-ran when the showMultipleYAxes toggle flipped — deselecting a topic dropped its series but left its y-axis behind, and axes accumulated as topics were toggled. The axis-building logic is factored into a shared applyMultiYAxisConfigs helper used by both the toggle effect and updateChart; the read in updateChart is untracked so it doesn't add showMultipleYAxes as a dependency of the subscription effect.

Notes

Single-axis behavior is untouched — its min/max is still owned by the graphConfig effect, so that path is left alone.

Local live verification with verify-graph could not be run in this environment (no Docker daemon → no backend/telemetry data). Verified via build, lint/prettier, and a unit spec driving the axis seam. verify-graph should be run on a Docker-capable machine before merge.

Test Cases

  • Multi-axis on: one y-axis per topic in the data map.
  • Deselect a topic: its y-axis is pruned, remaining axes match remaining series.
  • Axis sides alternate left/right as topics are added.

Checklist

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #630


Generated by Claude Code

Rebuild per-topic y-axis configs in updateChart so the axis set always
matches the current series. Previously the multi-y-axis effect only re-ran
when the showMultipleYAxes toggle flipped, leaving stale axes when a topic
was deselected.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DbmqjZpN8tex2sPd1h9HTU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix lingering y-axis when deselecting topic with multiple y-axes

2 participants