#630 - prune lingering y-axis when deselecting topic in multi-axis mode#717
Draft
bracyw wants to merge 1 commit into
Draft
#630 - prune lingering y-axis when deselecting topic in multi-axis mode#717bracyw wants to merge 1 commit into
bracyw wants to merge 1 commit into
Conversation
Rebuild per-topic y-axis configs in updateChart so the axis set always matches the current series. Previously the multi-y-axis effect only re-ran when the showMultipleYAxes toggle flipped, leaving stale axes when a topic was deselected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DbmqjZpN8tex2sPd1h9HTU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
With Multiple Y-Axes enabled, the graph page's y-axis configs are now rebuilt in updateChart from the current data map, so the axis set always matches the selected topics. Previously the multi-y-axis effect only re-ran when the showMultipleYAxes toggle flipped — deselecting a topic dropped its series but left its y-axis behind, and axes accumulated as topics were toggled. The axis-building logic is factored into a shared applyMultiYAxisConfigs helper used by both the toggle effect and updateChart; the read in updateChart is untracked so it doesn't add showMultipleYAxes as a dependency of the subscription effect.
Notes
Single-axis behavior is untouched — its min/max is still owned by the graphConfig effect, so that path is left alone.
Local live verification with verify-graph could not be run in this environment (no Docker daemon → no backend/telemetry data). Verified via build, lint/prettier, and a unit spec driving the axis seam. verify-graph should be run on a Docker-capable machine before merge.
Test Cases
Checklist
package-lock.jsonchanges (unless dependencies have changed)Closes #630
Generated by Claude Code