Repository navigation
Conversation
EnRaiha
added
the
run-ci
EnRaiha
changed the title
EnRaiha
force-pushed
the
fix/shaper-error-class
branch
from
September 20, 2026 14:45
92ed12f to
d7190b3
Compare
The streamed path rendered decode and shape failures as XX000 with a raw message, and the DDL dispatch did the same over a RETURNING shape failure, so a class the error already carried reached the client as an internal fault. Both now render through the classified path (error_to_sqlstate for the stream's crate::Error, numeric_code_to_sqlstate for the shaper's NodeDbError) with shaping_error_message hygiene. The two 'payload was not a row array' invariants keep XX000 by decision.
EnRaiha
force-pushed
the
fix/shaper-error-class
branch
from
September 20, 2026 14:48
d7190b3 to
c625004
Compare
EnRaiha
added this pull request to stack #363
September 20, 2026 14:54
EnRaiha
added
run-ci
Member
|
Closing: stacked on #359, which conflicts with main, and CI fails here. Resubmit against main once the mapper PR lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two surfaces still hardcoded the class after the routed sites went through the mapper and the mapper table was completed (PR stacked below):
XX000.Stacked on #359, which fixes #338. Top of the two-PR stack.
What
error_to_sqlstatewith the sameshaping_error_messagehygiene; the two "payload was not a row array" invariants keepXX000by decision.XX000.Validation
cargo check -p nodedb --all-targets— clean.cargo test -p nodedb --lib error_map— 35 passed.cargo test -p nodedb-types— 750 passed.cargo clippy -p nodedb -p nodedb-types --all-targets -- -D warnings— clean.cargo fmt --all -- --check— clean.Notes for review
Read the mapper PR first; this one only moves the two remaining surfaces onto it.
Tradeoffs
Tradeoff: the two "payload was not a row array" invariants keep
XX000by decision.