Repository navigation
fix(sql): keep one cell per duplicate constant column - #327
Merged
Merged
Conversation
`SELECT nextval('s'), nextval('s')` legally repeats an output name. The
constant-result row is a JSON object keyed by column name, so the second
cell overwrote the first and both wire columns rendered the last value.
Key the payload and the output schema's lookup keys by the same unique
per-column keys every response encoder derives, so each column keeps its
own cell.
EnRaiha
force-pushed
the
fix/constant-row-cell-keys
branch
from
September 17, 2026 06:10
55a42e7 to
22a0f42
Compare
farhan-syah
approved these changes
Sep 17, 2026
farhan-syah
left a comment
Member
There was a problem hiding this comment.
Approve.
Verified statically against the branch ref (no checkout):
| Claim | Result |
|---|---|
cargo fmt --all no change |
Confirmed. rustfmt --check clean on all three files. |
| One commit, three files | Confirmed. 22a0f42, +59 / −13. |
Test fails on main |
Consistent with the code. On main both cells land under nextval, so the row holds one value and both columns read it. |
| Comment hygiene | Clean. No issue numbers, links, or pre-fix narration. |
Layer is correct. Both producers of the constant-result shape (set_ops.rs payload, build.rs schema) now derive keys from cell_keys, the one function every encoder already reads through. No fallback, no second accepted shape.
Out of scope for this PR, tracked separately: the extended-query path (pgwire/handler/prepared/execute.rs) rebuilds its projection from the Describe fields with lookup_key = field name, and that projection overrides the planner schema (routing/execute.rs). SELECT nextval('s'), nextval('s') over Bind/Execute still collapses, as does SELECT w.id, b.id. That defect predates this PR.
4 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SELECT nextval('a'), nextval('a')legally repeats an output name. The constant-result row is a JSON object keyed by column name, so the second cell overwrote the first and both wire columns rendered the last value. The payload and the output schema's lookup keys now use the same unique per-column keys every response encoder derives.Red proof (the test fails on
mainwithout the fix)Validation (local, on this branch)
sql_sequences+cell_keys+output_schemacargo fmt --allcargo clippy -p nodedb --all-targets --all-features --profile ci -- -D warningsOne commit; touches
sql_plan_convert/output_schema/build.rs,sql_plan_convert/set_ops.rs, and the new wire test only.