Repository navigation
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for static gates
Fix Calvin determinism gate failure in test-only sub-plan task builder
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Static gates / Static gates (pull_request)job failed incheck_calvin_determinism.shdue to an unmarkedInstant::now()use in the Calvin write-path scan scope (sub_plan.rs). The call is test-only and not part of WAL/state mutation, but it still must satisfy the gate’s line-local marker rule.Root cause
nodedb/src/data/executor/handlers/transaction/sub_plan.rshadInstant::now()inside#[cfg(test)] build_dummy_task.Code change
// no-determinism: ...marker to theInstant::now()site (or immediately above it) so the call is explicitly exempt per gate contract.Gate-contract example