Skip to content

Fix Calvin determinism gate failure in test-only sub-plan task builder - #282

Closed
EnRaiha with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-static-gates-job-failure
Closed

EnRaiha with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-static-gates-job-failure

Conversation

Copilot AI commented Sep 4, 2026 •

Copy link
Copy Markdown

The Static gates / Static gates (pull_request) job failed in check_calvin_determinism.sh due to an unmarked Instant::now() use in the Calvin write-path scan scope (sub_plan.rs). The call is test-only and not part of WAL/state mutation, but it still must satisfy the gate’s line-local marker rule.

  • Root cause

    • nodedb/src/data/executor/handlers/transaction/sub_plan.rs had Instant::now() inside #[cfg(test)] build_dummy_task.
    • Existing rationale text was not on the same line or directly preceding line, so the grep-based determinism gate flagged it.
  • Code change

    • Added/moved an inline // no-determinism: ... marker to the Instant::now() site (or immediately above it) so the call is explicitly exempt per gate contract.
    • Kept behavior unchanged; this is a gate-compliance annotation fix for a test-only helper.
  • Gate-contract example

    // no-determinism: test-only ephemeral deadline, not persisted to Calvin/WAL state.
    std::time::Instant::now() + std::time::Duration::from_secs(60)

Copilot AI changed the title [WIP] Fix failing GitHub Actions job for static gates Fix Calvin determinism gate failure in test-only sub-plan task builder Sep 4, 2026
Copilot AI requested a review from EnRaiha September 4, 2026 06:38
@EnRaiha EnRaiha added the run-ci Opt this PR into the full test suite; re-add to force a re-run label Sep 4, 2026
@farhan-syah farhan-syah closed this Sep 4, 2026
@farhan-syah
farhan-syah deleted the copilot/fix-static-gates-job-failure branch September 6, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-ci Opt this PR into the full test suite; re-add to force a re-run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants