Lure - #269
Open
ZeChrales wants to merge 5 commits into
Open
Conversation
"Speed up PokéStop responses"
evenly-epic-mule
left a comment
evenly-epic-mule
left a comment
Contributor
There was a problem hiding this comment.
Nice Work! 👍
could you maybe still add a sql file for adding the column, as I think it is not updated / added by monocle it self
| '<br>=> <a href=https://www.google.com/maps/?daddr='+ item.lat + ','+ item.lon +' target="_blank" title="See in Google Maps">Get directions</a>'); | ||
| marker.bindPopup( | ||
| '<b>Pokestop: ' + expireDate + '</b>' + | ||
| '<br>=> <a href=https://www.google.com/maps/?daddr=' + item[1] + ',' + item[2] + |
Contributor
There was a problem hiding this comment.
would be nice to have the link in qotation href="https://[...]"
Contributor
Author
|
yeah I had to change some things in database, I'm waiting for Noctem's merge to check the upgrade of database |
|
Is there any chance this PR be merged ? (since one month) =) |
cptmedic
approved these changes
Jul 30, 2017
|
I agree this is actually something I would love to see. We are hosting lure parties near weekly and I feel those that are aware who use the maps would migrate over if they saw them on the map |
|
Exactly same as you. =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
display pokestops lured on web map
db changes & new pokestops query