love2d - #131
Merged
Merged
love2d#131
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for the love2d.nvim plugin to this Nix-managed Neovim configuration, and updates pinned dependencies (including upgrading npins format) to keep the flake reproducible.
Changes:
- Add a lazy spec to configure
love2d.nvimonDeferredUIEnter. - Harden
lua_lson_inithandling around workspace detection (but see comments about remaining issues). - Update
npinspins + generatednpins/default.nix, and refreshflake.lockinputs.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugins/nobbz/lua/nobbz/plugins/love2d.lua | Adds lazy-loading spec + setup call for love2d.nvim. |
| plugins/nobbz/lua/nobbz/lsp/clients/lua.lua | Wraps lua_ls on_init logic with a workspace check. |
| npins/sources.json | Updates pinned plugin/tool sources; adds nvim-love2d; bumps format version. |
| npins/default.nix | Updates generated npins fetcher logic to support sources.json v8. |
| nix/mnw/default.nix | Adds love2d to the MNW plugin start list. |
| flake.lock | Refreshes flake inputs (nixpkgs, flake-parts, etc.). |
Suppressed comments (1)
plugins/nobbz/lua/nobbz/lsp/clients/lua.lua:32
vim.iter(...):map(...)returns an iterator, not a plain table;table.insert(plugin_paths, ...)will fail. Alsostring.sub(plugin_path, -1, -4)returns an empty string (start index after end index), so the computed library paths are wrong.
local plugin_paths = vim.split(vim.fn.glob(glob_path), "\n", { trimempty = true, })
plugin_paths = vim.iter(plugin_paths):map(function(plugin_path) return string.sub(plugin_path, -1, -4) end)
table.insert(plugin_paths, vim.env.VIMRUNTIME)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+18
to
20
| if client.workspace_folders then | ||
| local path = client.workspace_folders[1].name | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.