Skip to content

love2d - #131

Merged
NobbZ merged 2 commits into
mainfrom
push-myyrtwrvpyws
Aug 8, 2026
Merged

love2d#131
NobbZ merged 2 commits into
mainfrom
push-myyrtwrvpyws

Conversation

@NobbZ

@NobbZ NobbZ commented Aug 8, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the love2d.nvim plugin to this Nix-managed Neovim configuration, and updates pinned dependencies (including upgrading npins format) to keep the flake reproducible.

Changes:

  • Add a lazy spec to configure love2d.nvim on DeferredUIEnter.
  • Harden lua_ls on_init handling around workspace detection (but see comments about remaining issues).
  • Update npins pins + generated npins/default.nix, and refresh flake.lock inputs.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
plugins/nobbz/lua/nobbz/plugins/love2d.lua Adds lazy-loading spec + setup call for love2d.nvim.
plugins/nobbz/lua/nobbz/lsp/clients/lua.lua Wraps lua_ls on_init logic with a workspace check.
npins/sources.json Updates pinned plugin/tool sources; adds nvim-love2d; bumps format version.
npins/default.nix Updates generated npins fetcher logic to support sources.json v8.
nix/mnw/default.nix Adds love2d to the MNW plugin start list.
flake.lock Refreshes flake inputs (nixpkgs, flake-parts, etc.).
Suppressed comments (1)

plugins/nobbz/lua/nobbz/lsp/clients/lua.lua:32

  • vim.iter(...):map(...) returns an iterator, not a plain table; table.insert(plugin_paths, ...) will fail. Also string.sub(plugin_path, -1, -4) returns an empty string (start index after end index), so the computed library paths are wrong.
    local plugin_paths = vim.split(vim.fn.glob(glob_path), "\n", { trimempty = true, })
    plugin_paths = vim.iter(plugin_paths):map(function(plugin_path) return string.sub(plugin_path, -1, -4) end)
    table.insert(plugin_paths, vim.env.VIMRUNTIME)

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +18 to 20
if client.workspace_folders then
local path = client.workspace_folders[1].name

@NobbZ
NobbZ merged commit e1ea6f9 into main Aug 8, 2026
3 checks passed
@NobbZ
NobbZ deleted the push-myyrtwrvpyws branch August 8, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants