Repository navigation
expo-cli: init + implement overrideNodeAttrs - #96509
Conversation
|
cc @FRidh who implemented cc @Scriptkiddi who was also interested in this |
|
While I am not sure whether it is the correct direction to add these language/framework-specific overrides (see NixOS/rfcs#67 (comment)) I do think the implementation in #87394 would be preferred over us implementing our own ones every time. |
|
Thanks, I was trying to find the PR but did not realize it was closed. I agree with you but in the meantime I would like a working, if only temporary solution. What do you think about gating it on explicit acknowledgement that the function can be dropped at any time? |
|
Well, I say we should just use that PR. Having those override functions does not preclude having a common override function which I proposed (that could be say |
mimicking the buildPythonPackage's overridePythonAttrs function
|
I think I will use the local internal function for now, rather than switching to a public API that would be deprecated after RFC 67. I will port to that once it gets accepted. |
Motivation for this change
Closes: #93399
Had to implement
overrideNodeAttrsto filter out optional@expo/traveling-fastlane-darwindependency that was intentionally aborting the build on Linux.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)