cmake: 3.15.4 -> 3.16.2

[tobim]

Motivation for this change

The announcement: https://discourse.cmake.org/t/cmake-3-16-0-available-for-download/262
The release page: https://cmake.org/cmake/help/v3.16/release/3.16.html

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @

[FRidh]

needs rebase

[jtojnar]

We have added a patch to CMake in #74282, this will need to be removed before merging.

[tobim]

We have added a patch to CMake in #74282, this will need to be removed before merging.

Thanks, done.

[tobim]

@jtojnar would you mind having another look?

[jtojnar]

Looking at the changelog:

The “CMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY” variable has been
deprecated. Use the “CMAKE_FIND_USE_PACKAGE_REGISTRY” variable
instead.

$ rg CMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY
pkgs/development/libraries/quickder/default.nix
43:    "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON"

pkgs/development/tools/build-managers/cmake/setup-hook.sh
99:    cmakeFlags="-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON $cmakeFlags"

Otherwise the changelog looks fine.

[tobim]

Good catch! Your feedback is integrated.

[jtojnar]

Thanks.