Skip to content

nixos-shell:init at 2015-05-23 - #73192

Closed
pasqui23 wants to merge 5 commits into
NixOS:masterfrom
pasqui23:nosh
Closed

nixos-shell:init at 2015-05-23#73192
pasqui23 wants to merge 5 commits into
NixOS:masterfrom
pasqui23:nosh

Conversation

@pasqui23

@pasqui23 pasqui23 commented Nov 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 11, 2019
@nixos-discourse

nixos-discourse commented Dec 2, 2019

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/86

@teto

teto commented Dec 2, 2019

Copy link
Copy Markdown
Member

isn't the upstream at https://github.com/Mic92/nixos-shell ?

@pasqui23

pasqui23 commented Dec 3, 2019

Copy link
Copy Markdown
Contributor Author

You're right,and it's even more recently updated

@pasqui23

pasqui23 commented Dec 3, 2019

Copy link
Copy Markdown
Contributor Author

That one has the same name but it's different:it spawns a whole new virtual machine instead of just a container

@tomberek

tomberek commented Dec 8, 2019

Copy link
Copy Markdown
Contributor

nixos-container is required at runtime, but is not in the dependencies nor propagated. And should it be limited to NixOS? or can someone run nixos-container on non-NixOS?

@pasqui23

pasqui23 commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

@tomberek it is merely a thin wrapper aroun nixos-container,so it should run where nixos-container runs

@pasqui23

pasqui23 commented Jan 15, 2020

Copy link
Copy Markdown
Contributor Author

Ok,why the check meta fails?

c0bw3b
c0bw3b reviewed Jan 17, 2020
View reviewed changes
Comment thread pkgs/tools/package-management/nixos-shell/default.nix Outdated
@pasqui23 @c0bw3b
nixos-shell: corret meta
7bb1f9b 
Co-Authored-By: Renaud <c0bw3b@users.noreply.github.com>
@doronbehar

doronbehar commented May 23, 2020

Copy link
Copy Markdown
Contributor

Closed in favor of #85673 .

@doronbehar doronbehar closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@c0bw3b c0bw3b c0bw3b left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pasqui23 @nixos-discourse @teto @tomberek @doronbehar @c0bw3b