Skip to content

devenv: 2.3.0 -> 2.3.1 - #562437

Merged
drupol merged 2 commits into
NixOS:masterfrom
domenkozar:devenv-2.3.1
Sep 12, 2026
Merged

drupol merged 2 commits into
NixOS:masterfrom
domenkozar:devenv-2.3.1

Conversation

@domenkozar

@domenkozar domenkozar commented Sep 12, 2026 •

Copy link
Copy Markdown
Member

Patch release of devenv. Changelog: https://github.com/cachix/devenv/releases/tag/v2.3.1

Only the version, source hash and cargoHash change. The pinned cachix/nix revision is unchanged.

Disclosure: this pull request summary and the commit were produced with Claude Code (Claude Fable 5.1), reviewed by me.

Things done

@nixpkgs-ci
nixpkgs-ci Bot requested a review from sandydoo September 12, 2026 01:01
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 12, 2026
@RossSmyth

Copy link
Copy Markdown
Contributor

Please follow the PR guidelines, do not delete them, or as I suspect in this instance it was completely ignored and the text seen here is just whatever the llm calculated based upon its training windows. This PR blatantly does not follow contribution guidelines. Please reopen when it does.

@RossSmyth RossSmyth closed this Sep 12, 2026
@domenkozar

Copy link
Copy Markdown
Member Author

Never seen you interested into devenv, but it's good you care :)

Could you explain which rule I've violated?

@fzakaria

Copy link
Copy Markdown
Contributor

This a pretty mundane change.

I'm also genuinely curious why this was closed or what was the missing/incorrect part?

@arianvp arianvp reopened this Sep 12, 2026
@NyCodeGHG

NyCodeGHG commented Sep 12, 2026 •

Copy link
Copy Markdown
Member

Please read the Automation Policy.
You are not using the PR template, it's missing the "I read the Automation Policy Checkbox" and it still lists x86_64-darwin.
You also did not correctly mark your commit as AI-assisted according to the Automation Policy.

@jackrosenberg jackrosenberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why require Assisted-by: over Co-authored-by:?

Since LLM‐based AI tools use Co-authored-by: attribution by default, we think that using a different format will serve as a brown M&M test and assist with triage. A commit that contains such a tool in Co-authored-by: but not Assisted-by: is, by definition, one that did not follow the policy and can be closed, potentially automatically. It also matches the format standardized on by the Linux kernel and Fedora, and will make it easier to review and query for use of these tools.

The disregard for following guidelines shows a concerning level of apathy.

@SigmaSquadron SigmaSquadron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(As mentioned above. This change request is just to prevent an accidental merge.)

@vcunat

vcunat commented Sep 12, 2026

Copy link
Copy Markdown
Member

Honestly, the change is trivial, so I believe it doesn't matter whether the hashes were copy&pasted manually or generated in any other way. Why add complicated hurdles in cases where the benefit doesn't really exist?

@SigmaSquadron

SigmaSquadron commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Because its our agreed upon policy. We're not asking the author to cease using AI, despite its many issues in environmental, ethical, quality and legal domains. We're simply asking a minimal amount of respect for our existing guidelines.

@vcunat

vcunat commented Sep 12, 2026 •

Copy link
Copy Markdown
Member

This was marked as generated with help of AI from the very start. (in the commit message)

@domenkozar

domenkozar commented Sep 12, 2026 •

Copy link
Copy Markdown
Member Author

What happened here is that I have a release process as part of devenv in that repository, and it didn't pick up CLAUDE.md from nixpkgs when doing the PR.

I'll fix that so that it respects the template and the commit format.

These changes are really trivial, of course you can pick up on me if you want, but it shows a lack of empathy for only trying to maintain my software.

Worth mentioning is that none of this behavior will make me stop using AI.

@domenkozar
domenkozar force-pushed the devenv-2.3.1 branch 2 times, most recently from 5a77576 to 7858cc0 Compare September 12, 2026 13:44
@nixpkgs-ci nixpkgs-ci Bot added the llm-assisted Contributions that include code generation with LLMs label Sep 12, 2026
@SigmaSquadron

Copy link
Copy Markdown
Contributor

This was marked as generated with help of AI from the very start. (in the commit message)

It was not marked in a way that was compliant with our pre-established guidelines.

Worth mentioning is that none of this behavior will make me stop using AI.

As I previously mentioned, no one here is trying to stop you from using whatever automation tools you deem appropriate. We're just asking you to follow the rules agreed upon by the community over the usage of said tools. The fact that you enjoy using these tools does not put you in a position to disregard our guidelines.

@SigmaSquadron

Copy link
Copy Markdown
Contributor

Please note that the reviews still stand, as the co-authored-by tag is invalid per our policy.

Changelog: https://github.com/cachix/devenv/releases/tag/v2.3.1

Assisted-by: Claude Code (Claude Fable 5.1)
@domenkozar

Copy link
Copy Markdown
Member Author

Please note that the reviews still stand, as the co-authored-by tag is invalid per our policy.

Having a Co-authored-by trailer alongside Assisted-by is not prohibited anywhere in the text.

@jackrosenberg

Copy link
Copy Markdown
Member

Literally all they had to do was follow the guidelines.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Sep 12, 2026
@EpicEric

Copy link
Copy Markdown
Member

@drupol To be clear, nobody argued against the LLM usage, the disagreement was that the pull request template and AI contribution guidelines were not followed.

@drupol

drupol commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (07e0eb6)

Command: nixpkgs-review pr 562437
Commit: f3f59c37723f46de21ace5e88dfcdfa63b6dabab (subsequent changes)
Merge: da5ca5203635381497d1dede9c50fc78204e73f0

Logs: https://github.com/drupol/nixpkgs-review-gha/actions/runs/34714661557/attempts/1


x86_64-linux

✅ 1 package built:
  • devenv

aarch64-linux

✅ 1 package built:
  • devenv

x86_64-darwin

✅ No rebuilds


aarch64-darwin (sandbox = relaxed)

✅ 15 packages built:
  • cachix
  • devenv
  • haskellPackages.cachix
  • haskellPackages.hercules-ci-agent
  • haskellPackages.hercules-ci-cli
  • haskellPackages.hercules-ci-cnix-expr
  • haskellPackages.hercules-ci-cnix-store
  • hci
  • hercules-ci-agent
  • nix-heuristic-gc
  • nix-inspect
  • nix-plugins
  • nixVersions.nix_2_31
  • omnix
  • tests.haskell.cabalSdist.hercules-ci-cnix-store

@drupol drupol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@drupol
drupol added this pull request to the merge queue Sep 12, 2026
Merged via the queue into NixOS:master with commit ea49258 Sep 12, 2026
28 checks passed
@xokdvium

Copy link
Copy Markdown
Contributor

Are we really going to apply patches to nix without getting a nix team sign off? It's a backport but still, wtf?

@domenkozar

Copy link
Copy Markdown
Member Author

Feel free to revert it if you think there's something wrong with that patch.

It's there to unblock nixpkgs-unstable.

@xokdvium

Copy link
Copy Markdown
Contributor

I'm not looking to revert, just please be kind and give a bit of grace for people to look at the stuff. If you'd prefer, that can also be backported in the nix tree so that we are not carrying patches around.

@domenkozar

Copy link
Copy Markdown
Member Author

I'll make backport PRs in the nix repo tomorrow.

Sorry for the mess, I hope we unblocked nixpkgs and fixed some devenv regressions.

@vcunat

vcunat commented Sep 13, 2026 •

Copy link
Copy Markdown
Member

the disagreement was that the pull request template and AI contribution guidelines were not followed

  • AI usage had been disclosed from the very start in the commit message; yes, by a slightly different line than required by the contribution guidelines
  • the template was fixed before the PR got closed (that's what I see in the GitHub's edit log above)

@vcunat

vcunat commented Sep 13, 2026

Copy link
Copy Markdown
Member

Also, interestingly, Domen got basically abused on https://matrix.to/#/#dev:nixos.org in parallel with this PR's discussion. Personal attacks pass OK but these nits are against guidelines?

As for the guidelines, they require to "transparently disclose any non‐trivial use of automation". The discussion happened on a simple bump of version+hashes (4 lines), which I'd argue is quite trivial in this respect.

@domenkozar

Copy link
Copy Markdown
Member Author

I've worked on this project for more than 10 years and I have no idea why I deserve this treatment.

Especially on PRs like this where we fix bugs that would need to be rolled out fast to address issues people face with OSS we give for free.

But okay, keep going with the hate, I hope it works out for you all.

attilaolah added a commit to attilaolah/os that referenced this pull request Sep 14, 2026
attilaolah added a commit to attilaolah/os that referenced this pull request Sep 14, 2026
* chore(deps): update flake

Pin to dramatic PR NixOS/nixpkgs#562437 ;)

* fix: bump suitparse version assertion, still no CUDA support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. llm-assisted Contributions that include code generation with LLMs

Projects

None yet

Development

Successfully merging this pull request may close these issues.