nixos-rebuild-ng: replace get_generations with a shell-based approach - #560972
Closed
thiagokokada wants to merge 1 commit into
Closed
thiagokokada wants to merge 1 commit into
thiagokokada wants to merge 1 commit into
Conversation
thiagokokada
force-pushed
the
unify-get-generations
branch
from
September 7, 2026 18:05
d62067b to
6060141
Compare
thiagokokada
marked this pull request as ready for review
September 7, 2026 18:09
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
thiagokokada
force-pushed
the
unify-get-generations
branch
3 times, most recently
from
September 7, 2026 18:28
2c4a0d3 to
b863045
Compare
Contributor
Author
|
CC @r-vdp could you help review this PR? |
Contributor
I'm currently on holidays for another 10 days trying to stay away from my laptop as much as possible. But I'll take a look and test this once I'm back home! |
thiagokokada
force-pushed
the
unify-get-generations
branch
3 times, most recently
from
September 11, 2026 12:29
4f44831 to
209d185
Compare
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
Contributor
Author
Friendly ping @r-vdp. Hope you got some good holidays. |
r-vdp
requested changes
Sep 24, 2026
nixpkgs-ci
Bot
removed
the
2.status: merge-bot eligible
Port the old Python logic to POSIX's shell and remove the usage of `nix-env --list-generations`. While the original objective of `nixos-rebuild-ng` was to avoid having logic written in shell scripting, the only way to unify the two separate approaches of get_generations was to write this in shell, because we also need to run this remotely, but sadly calling `nix-env --list-generations` needs root (NixOS/nix#5144). This also fixes a long standing issue of `nix-collect-garbage` causing the `nixos-rebuild list-generations` to report the wrong build-date after a `nix-collect-garbage` or `nix store optimise`. Fix NixOS#435555.
thiagokokada
force-pushed
the
unify-get-generations
branch
from
September 24, 2026 18:26
209d185 to
76478e4
Compare
Contributor
Author
|
@r-vdp Done, can I get a re-review? |
Contributor
Author
|
So I got the issue that made using I assume we will get this fixed in the next |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the old Python logic to POSIX's shell and remove the usage of
nix-env --list-generations.While the original objective of
nixos-rebuild-ngwas to avoid having logic written in shell scripting, the only way to unify the two separate approaches of get_generations was to write this in shell, because we also need to run this remotely, but sadly callingnix-env --list-generationsneeds root (NixOS/nix#5144).This also fixes a long standing issue of
nix-collect-garbagecausing thenixos-rebuild list-generationsto report the wrong build-date after anix-collect-garbageornix store optimise.Fix #435555.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.