Skip to content

linuxManualConfig: keep whole scripts dir following symlink - #444161

Closed
qbisi wants to merge 1 commit into
NixOS:masterfrom
qbisi:deviceTree
Closed

linuxManualConfig: keep whole scripts dir following symlink#444161
qbisi wants to merge 1 commit into
NixOS:masterfrom
qbisi:deviceTree

Conversation

@qbisi

@qbisi qbisi commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

We keep the whole script directory for linux^dev, however some symlinks to upper directory are ommitted.
This pr keep the whole script directory following symlinks.

Part of #403746
Previous pr #379794

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware Drivers, Firmware and Kernels labels Sep 18, 2025
@K900

K900 commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Literally every issue raised on the previous iterations of this change stands.

@qbisi

qbisi commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

Literally every issue raised on the previous iterations of this change stands.

You mean not using pkgs.srcOnly and?

@nixpkgs-ci nixpkgs-ci Bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware Drivers, Firmware and Kernels labels Sep 20, 2025
@qbisi qbisi changed the title nixos/device-tree: add option dtstext/dtsFile/dtbFile linuxManualConfig: keep whole scripts dir following symlink Sep 20, 2025
@qbisi qbisi closed this Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TredwellGit TredwellGit Awaiting requested review from TredwellGit
@Ma27 Ma27 Awaiting requested review from Ma27
@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus
@alyssais alyssais Awaiting requested review from alyssais
@K900 K900 Awaiting requested review from K900
@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

No one assigned

Labels

6.topic: kernel The Linux kernel 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qbisi @K900