Skip to content

netbird: remove misuzu as maintainer - #341812

Merged
2 commits merged into
NixOS:masterfrom
misuzu:netbird-update
Sep 15, 2024
Merged

2 commits merged into
NixOS:masterfrom
misuzu:netbird-update

Conversation

@misuzu

@misuzu misuzu commented Sep 14, 2024

Copy link
Copy Markdown
Contributor

Description of changes

I've migrated to tailscale and I'm not able to reliably test this package anymore

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 14, 2024
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 14, 2024
@Aleksanaa

Copy link
Copy Markdown
Member

@vrifox would you like to maintain the NixOS module and test?

@ghost

ghost commented Sep 14, 2024

Copy link
Copy Markdown

@Aleksanaa I'm fairly new to maintaining packages, but I will do my best, yes. :)

@github-actions

Copy link
Copy Markdown
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-341812-to-release-24.05 origin/release-24.05
cd .worktree/backport-341812-to-release-24.05
git switch --create backport-341812-to-release-24.05
git cherry-pick -x ad3c462a6ecdabfaa0ae4f5d694ba3f299247b96 2505777e0c90e4ae553b40033dfd931aaa442ea5

@nazarewk

nazarewk commented Sep 17, 2024 •

Copy link
Copy Markdown
Member

I'm actually driving Netbird daily with no plan to stop in foreseeable future, but I wouldn't really be able to maintain it until my PR is merged

@misuzu
misuzu deleted the netbird-update branch January 21, 2025 21:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants