installer: support BusyBox cp - #16537
Merged
Merged
Conversation
fgaz
force-pushed
the
installer-busybox
branch
from
September 28, 2026 12:38
ed15611 to
c185669
Compare
fgaz
changed the title
Contributor
|
Could you try adding a test for alpine images? https://github.com/NixOS/nix/blob/master/tests/installer/default.nix |
lisanna-dettwyler
approved these changes
Sep 28, 2026
fgaz
force-pushed
the
installer-busybox
branch
2 times, most recently
from
September 28, 2026 13:06
91df610 to
9e4445e
Compare
xokdvium
reviewed
Sep 28, 2026
xokdvium
reviewed
Sep 28, 2026
fgaz
force-pushed
the
installer-busybox
branch
from
September 28, 2026 13:12
9e4445e to
2070b62
Compare
This uncovers a latent bug in the tests: `MAYBESUDO: unbound variable` dating back to 717e81d. `sudo` was never actually needed and root's channel was never modified because the undefined variable was expanded on the host and not the VM under test. Keeping the test's behavior the same, we can safely remove the entire MAYBESUDO machinery without functional changes.
Fixes NixOS#13480 Multi-user installs on alpine are not yet supported and thus aren't modified. Also it seems tricky to reliably figure out which `cp` binary would be used by `root`. Co-authored-by: Sergei Zimmerman <sergei@zimmerman.foo>
xokdvium
force-pushed
the
installer-busybox
branch
from
September 28, 2026 16:43
2070b62 to
f0ebb3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #13480
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.