Conversation
xokdvium
reviewed
Sep 25, 2026
Comment on lines
127
to
+128
| for (size_t i = 0; args[i]; i++) | ||
| p->args.emplace_back(*args); | ||
| p->args.emplace_back(args[i]); |
Contributor
There was a problem hiding this comment.
Hm, also this comes to mind. Why is there multiple sources of truth for the number of arguments (namely arity and the loop termination condition with there being a trailing NUL element in the array).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The type for args in nix_alloc_primop was
const char **, meaning a mutable array of const strings. We actually don't mutate the array, so it's fine to make it const instead. This makes the generated rust api less awkward.Also, the first argument name was copied over instead of the correct one.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.