Create a second Store::getFSAccessor for a single store object - #14049
Merged
Merged
Conversation
github-actions
Bot
added
new-cli
Ericson2314
force-pushed
the
per-object-fs-accessor
branch
3 times, most recently
from
September 22, 2025 19:55
cd83dd5 to
fb88258
Compare
xokdvium
reviewed
Sep 22, 2025
xokdvium
reviewed
Sep 22, 2025
Ericson2314
force-pushed
the
per-object-fs-accessor
branch
2 times, most recently
from
September 22, 2025 21:02
af8dc7f to
a1295b2
Compare
Member
|
With #14050, the global accessor won't be needed for evaluation anymore either, since every input is mounted separately on top of a |
Member
Author
|
Great! And I also have a fix for |
Ericson2314
commented
Sep 23, 2025
xokdvium
reviewed
Sep 24, 2025
xokdvium
left a comment
xokdvium
left a comment
Contributor
There was a problem hiding this comment.
Minor nitpicks, otherwise seems ok.
This is sometimes easier / more performant to implement, and independently it is also a more convenient interface for many callers. The existing store-wide `getFSAccessor` is only used for - `nix why-depends` - the evaluator I hope we can get rid of it for those, too, and then we have the option of getting rid of the store-wide method. Co-authored-by: Sergei Zimmerman <sergei@zimmerman.foo>
Ericson2314
force-pushed
the
per-object-fs-accessor
branch
from
September 24, 2025 19:49
eeb130f to
a97d6d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is sometimes easier / more performant to implement, and independently it is also a more convenient interface for many callers.
Context
The existing store-wide
getFSAccessoris only used fornix why-dependsI hope we can get rid of it for those, too, and then we have the option of getting rid of the store-wide method.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.