Typewriter: Don't allow illegal path characters for file names#237
Merged
Conversation
asiekierka
reviewed
Apr 24, 2026
| c = typewriter_Hit[tilex+(tiley*TW_TILE_WIDTH)]; | ||
|
|
||
| if (is_file_name && | ||
| (c=='<' || c=='>' || c==':' || c=='/' || c=='?' || c=='*')) |
Collaborator
There was a problem hiding this comment.
Please use the matching code snippet from FatFs to cover all cases: strchr("*:<>|\"\?\x7F", c)
Collaborator
Author
There was a problem hiding this comment.
i need to modify this to include forward slash because that also crashes, i'll do that tomorrow
Collaborator
|
Other than that, LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to save a song name or a sample name containing any of these characters will cause a crash. The characters are still allowed specifically on the song/inst/sample rename screens.
There's also a new theme colour representing a disabled typewriter key.
Here's a demonstration:
simplescreenrecorder-2026-04-24_17.24.08.mp4