Skip to content

fix(desktop): keep migrate dialog out of App tests - #3

Merged
Ninthless merged 1 commit into
mainfrom
trampoline-test-fix
Sep 10, 2026
Merged

fix(desktop): keep migrate dialog out of App tests#3
Ninthless merged 1 commit into
mainfrom
trampoline-test-fix

Conversation

@Ninthless

Copy link
Copy Markdown
Owner

Summary

  • Dismiss the Electron migrate overlay in the shared Vitest setup so App integration tests can query the shell landmarks.

Test plan

  • pnpm exec vitest run tests/integration/App.test.tsx tests/components/ElectronMigrateDialog.test.tsx

The trampoline modal aria-hides the shell. Dismiss it in the shared
Vitest setup so App integration queries can still see landmarks.
@gitnotebooks

gitnotebooks Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review these changes at https://app.gitnotebooks.com/Ninthless/StackFerry/pull/3

@Ninthless
Ninthless merged commit a034bfe into main Sep 10, 2026
4 checks passed
@Ninthless
Ninthless deleted the trampoline-test-fix branch September 10, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant