Skip to content

CI Deadlock fix - #24148

Closed
Aragas wants to merge 1 commit into
masterfrom
cherry-pick/pr-24147-ci-required-workflow-fix-to-master
Closed

Aragas wants to merge 1 commit into
masterfrom
cherry-pick/pr-24147-ci-required-workflow-fix-to-master

Conversation

@Aragas

@Aragas Aragas commented Sep 9, 2026

Copy link
Copy Markdown
Member

Cherry-pick of #24147 into master.


Fixed a deadlock where we require the main.yml workflow to be run and be successful and paths-ignore actually skipping the workflow execution

We now check whether the workflow should be skipped inside the workflow execution.

See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

Avoid requiring workflows that can be skipped.

Since we can't skip it, lets just mark it as successful 🤷‍♂️

@Aragas
Aragas requested a review from a team as a code owner September 9, 2026 12:27
@Aragas
Aragas requested a review from erri120 September 9, 2026 12:28
@Aragas

Aragas commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Cherry pick failed because of the lack of workflow permissions, to be fixed

@nexusmodsvortex
nexusmodsvortex Bot force-pushed the cherry-pick/pr-24147-ci-required-workflow-fix-to-master branch from f269ed0 to 185e96c Compare September 9, 2026 14:03
@Aragas Aragas closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant