study_area_run.sh: pre-flight bcfp-ref view is fresh., not $SCHEMA. (v0.41.2)#210
Merged
Merged
Conversation
…v0.41.2) Latent bug exposed by v0.41.1's --schema= flag. The pre-flight check at line 135 was looking for streams_vw_bcfp in the persist schema ($SCHEMA), but the bcfp reference view is a constant — hard-coded to fresh.streams_vw_bcfp in R/lnk_compare_mapping_code.R:78. The coincidence held while $SCHEMA == "fresh" was the only value in use. With --schema= overridable, the pre-flight now correctly checks fresh.streams_vw_bcfp independent of $SCHEMA. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Latent bug exposed by v0.41.1's
--schema=flag.The pre-flight check at
data-raw/study_area_run.sh:135was looking forstreams_vw_bcfpin$SCHEMA(the override-able persist schema). The bcfp reference view is a constant —R/lnk_compare_mapping_code.R:78hard-codesref_table = "fresh.streams_vw_bcfp". While$SCHEMAwas always"fresh", the coincidence held. With--schema=overridable, the check broke (FATAL "fresh_default.streams_vw_bcfp missing").Fix: pre-flight now checks
fresh.streams_vw_bcfpliterally, independent of$SCHEMA.Related Issues
Test plan
--config=default --schema=fresh_default: FATAL on the wrong-schema check.fresh.streams_vw_bcfp(matcheslnk_compare_mapping_code.R:78).🤖 Generated with Claude Code