Fix latent run_checks crash and unblock mypy v2#701
Open
h-mayorquin wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #701 +/- ##
==========================================
+ Coverage 79.62% 82.81% +3.18%
==========================================
Files 48 48
Lines 1890 1897 +7
==========================================
+ Hits 1505 1571 +66
+ Misses 385 326 -59
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mypy bump to v2.1.0 on
dev(13d0d67) surfaced a real latent bug inrun_checks: when a caller passedprogress_bar_classwithout also passingprogress_bar_options, the defaultNonewas being splatted directly into the progress-bar constructor and would raiseTypeError. This PR coalesces the kwargs to an empty dict before forwarding. The other change is a one-line annotation onavailable_checksin_registration.pyto satisfy mypy 2.x's strictervar-annotatedchecking and has no behavior impact.